Skip to content

install: apply ipv6 and swap patches on install script #3365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

install: apply ipv6 and swap patches on install script #3365

wants to merge 1 commit into from

Conversation

Williangalvani
Copy link
Member

@Williangalvani Williangalvani commented Jun 9, 2025 •
edited by sourcery-ai bot
Loading

needs more testing

Summary by Sourcery

Configure the install script to adjust swap size and disable IPv6 on the target system during installation.

Enhancements:

  • Configure the install script to set swap size to 1024MB
  • Append sysctl entries to disable IPv6 globally during installation

@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Jun 9, 2025 •
edited
Loading

Reviewer's Guide

The PR enhances the install script by configuring the system swap size to 1024MB and disabling IPv6 via sysctl entries during installation.

Sequence Diagram for install.sh System Configuration Updates

sequenceDiagram
    participant S as "install.sh"
    participant DSWAP as "/etc/dphys-swapfile"
    participant SYSCTL as "/etc/sysctl.conf"

    S->>DSWAP: Write "CONF_SWAPSIZE=1024"
    S->>SYSCTL: Append IPv6 disable settings
Loading

Flow Diagram for New Configuration Steps in install.sh

graph TD
    A[Start of added script section] --> B["Set CONF_SWAPSIZE=1024 in /etc/dphys-swapfile"];
    B --> C["Add IPv6 disable entries to /etc/sysctl.conf"];
    C --> D[End of added script section];
Loading

File-Level Changes

Change Details Files
Configure swap size during install
  • Introduce SWAP_CONF_FILE variable pointing to /etc/dphys-swapfile
  • Write CONF_SWAPSIZE=1024 to the swap configuration file
 install/install.sh
Disable IPv6 at install time
  • Define SYSCTL_CONF variable for /etc/sysctl.conf
  • Append net.ipv6.conf.*.disable_ipv6=1 entries to sysctl.conf
 install/install.sh
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Williangalvani